netdev - RE: [PATCH net-next] net: fec: fix dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AM5PR04MB313962280DF8C65B2D72ABE188D4A@AM5PR04MB3139.eurprd04.prod.outlook.com>
Date: Thu, 19 Oct 2023 01:58:37 +0000
From: Wei Fang <wei.fang@....com>
To: "Radu-nicolae Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>, Shenwei Wang
	<shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	"davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>
CC: "Sebastian Tobuschat (OSS)" <sebastian.tobuschat@....nxp.com>,
	dl-linux-imx <linux-imx@....com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] net: fec: fix dev_info pointer

Hi Radu,

> -----Original Message-----
> From: Radu-nicolae Pirea (OSS) <radu-nicolae.pirea@....nxp.com>
> Sent: 2023年10月19日 3:02
> To: Wei Fang <wei.fang@....com>; Shenwei Wang
> <shenwei.wang@....com>; Clark Wang <xiaoning.wang@....com>;
> davem@...emloft.net; edumazet@...gle.com; kuba@...nel.org;
> pabeni@...hat.com; robh@...nel.org
> Cc: Sebastian Tobuschat (OSS) <sebastian.tobuschat@....nxp.com>;
> dl-linux-imx <linux-imx@....com>; netdev@...r.kernel.org; Radu-nicolae
> Pirea (OSS) <radu-nicolae.pirea@....nxp.com>
> Subject: [PATCH net-next] net: fec: fix dev_info pointer
> 
> of_match_table.data contains pointers to struct platform_device_id, not
> struct fec_devinfo. A pointer to a fec_devinfo structure is stored in
> platform_device_id->driver_data.
> 
> This BUG makes the driver connect to a Generic PHY.
> 
> Discovered on Freescale i.MX6 Quad SABRE Automotive Board.
> 
> Fixes: b0377116decd ("net: ethernet: Use device_get_match_data()")
> Signed-off-by: Radu Pirea (NXP OSS) <radu-nicolae.pirea@....nxp.com>
> ---

A patch set [1][2] has been applied to netdev/net-next.git today. I think this
patch set can fix the problem you found.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=e6809dba5ec3
[2] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=50254bfe1438