netdev - Re: [PATCH net-next 3/5] ipv6: add new arguments to udp_tunnel6_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e569b2a1-8766-793a-a0c5-f901ef146198@kernel.org>
Date: Fri, 20 Oct 2023 09:53:48 -0600
From: David Ahern <dsahern@...nel.org>
To: Beniamino Galvani <b.galvani@...il.com>, netdev@...r.kernel.org
Cc: "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Guillaume Nault <gnault@...hat.com>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 3/5] ipv6: add new arguments to
 udp_tunnel6_dst_lookup()

On 10/20/23 5:55 AM, Beniamino Galvani wrote:
> We want to make the function more generic so that it can be used by
> other UDP tunnel implementations such as geneve and vxlan. To do that,
> add the following arguments:
> 
>  - source and destination UDP port;
>  - ifindex of the output interface, needed by vxlan;
>  - the tos, because in some cases it is not taken from struct
>    ip_tunnel_info (for example, when it's inherited from the inner
>    packet);
>  - the dst cache, because not all tunnel types (e.g. vxlan) want to
>    use the one from struct ip_tunnel_info.
> 
> With these parameters, the function no longer needs the full struct
> ip_tunnel_info as argument and we can pass only the relevant part of
> it (struct ip_tunnel_key).
> 
> This is similar to what already done for IPv4 in commit 72fc68c6356b
> ("ipv4: add new arguments to udp_tunnel_dst_lookup()").
> 
> Suggested-by: Guillaume Nault <gnault@...hat.com>
> Signed-off-by: Beniamino Galvani <b.galvani@...il.com>
> ---
>  drivers/net/bareudp.c     | 10 +++++++---
>  include/net/udp_tunnel.h  |  7 ++++---
>  net/ipv6/ip6_udp_tunnel.c | 33 ++++++++++++++++++---------------
>  3 files changed, 29 insertions(+), 21 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>