netdev - Re: [PATCH net] i40e: sync next_to_clean and next_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878f40e6-645e-4166-b60c-ba488638cc42@intel.com>
Date: Fri, 20 Oct 2023 10:19:37 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
CC: <netdev@...r.kernel.org>, David Miller <davem@...emloft.net>, "Jakub
 Kicinski" <kuba@...nel.org>, Tirthendu Sarkar <tirthendu.sarkar@...el.com>,
	<hq.dev+kernel@...fc.xyz>, Arpana Arland <arpanax.arland@...el.com>
Subject: Re: [PATCH net] i40e: sync next_to_clean and next_to_process for
 programming status desc



On 10/20/2023 3:56 AM, Maciej Fijalkowski wrote:
> On Thu, Oct 19, 2023 at 01:38:52PM -0700, Jacob Keller wrote:
>> From: Tirthendu Sarkar <tirthendu.sarkar@...el.com>
>>
>> When a programming status desc is encountered on the rx_ring,
>> next_to_process is bumped along with cleaned_count but next_to_clean is
>> not. This causes I40E_DESC_UNUSED() macro to misbehave resulting in
>> overwriting whole ring with new buffers.
>>
>> Update next_to_clean to point to next_to_process on seeing a programming
>> status desc if not in the middle of handling a multi-frag packet. Also,
>> bump cleaned_count only for such case as otherwise next_to_clean buffer
>> may be returned to hardware on reaching clean_threshold.
>>
>> Fixes: e9031f2da1ae ("i40e: introduce next_to_process to i40e_ring")
>> Suggested-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>> Reported-by: hq.dev+kernel@...fc.xyz
>> Reported by: Solomon Peachy <pizza@...ftnet.org>
>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217678
>> Tested-by: hq.dev+kernel@...fc.xyz
>> Tested by: Indrek Järve <incx@...tbite.net>
>> Signed-off-by: Tirthendu Sarkar <tirthendu.sarkar@...el.com>
>> Tested-by: Arpana Arland <arpanax.arland@...el.com> (A Contingent worker at Intel)
>> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
> 
> You missed my ack, so:
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> 

not sure why patchwork didn't pick this one up. Sorry about missing it.
Thanks!

-Jake