netdev - Re: r8152: error when loading the module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47d463bce1ef62ecb34b666f21d7dd0d7439ac23.camel@inf.elte.hu>
Date: Fri, 20 Oct 2023 08:33:41 +0200
From: Ferenc Fejes <fejes@....elte.hu>
To: Hayes Wang <hayeswang@...ltek.com>, Jakub Kicinski <kuba@...nel.org>
Cc: netdev <netdev@...r.kernel.org>, "linux-usb@...r.kernel.org"
	 <linux-usb@...r.kernel.org>
Subject: Re: r8152: error when loading the module

On Fri, 2023-10-20 at 05:59 +0000, Hayes Wang wrote:
> [...]
> > > On my machine r8152 module loading takes about one minute.
> > > 
> > > Its a Debian Sid:
> > > uname -a
> > > Linux pc 6.5.0-2-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.5.6-1
> > > (2023-10-07) x86_64 GNU/Linux
> > 
> > Did this device work fine with older kernels or this is the only
> > one
> > you tried? The code doesn't seem to have changed all that much
> > since
> > RTL8156B support was added.

Thanks for pointing this out. Indeed, its probably not the kernel as I
suggested before, see below.

> > 
> > > dmesg:
> > > 
> > > 
> > > [  899.522306] usbcore: registered new device driver r8152-
> > > cfgselector
> > > [  899.601295] r8152-cfgselector 2-1.3: reset SuperSpeed USB
> > > device number 4 using xhci_hcd
> > > [  927.789526] r8152 2-1.3:1.0: firmware: direct-loading firmware
> > > rtl_nic/rtl8156b-2.fw
> > > [  942.033905] r8152 2-1.3:1.0: load rtl8156b-2 v2 04/27/23
> > > successfully
> 
> Someone reports there is an error message when loading rtl8156b-2 v2
> 04/27/23.
> 	r8152 6-1:1.0: ram code speedup mode fail
> I don't find the same message for you.

That line was also in dmesg for sure, I just failed to copy-paste every
related bits.

> However, I check the firmware and find some wrong content.
> Could you remove /lib/firmware/rtl_nic/rtl8156b-2.fw and unplug the
> device.
> Then, plug the device and check it again.

Yes, I'll do that, but strangely enough the error has disappeared since
then. I played with the setup yesterday a little more. The NIC is
actually built into my monitor, which is always powered on - so
regardless if my laptop connected or not, the NIC is probably on. I
rebooted to Windows, and then rebooted to Linux, and magically the bug
just disappeared.

Is this possible/makes sense to you?

> 
> > > [  956.269444] ------------[ cut here ]------------
> > > [  956.269447] WARNING: CPU: 7 PID: 211 at
> > > drivers/net/usb/r8152.c:7668 r8156b_hw_phy_cfg+0x1417/0x1430
> > > [r8152]
> > > [  956.269458] Modules linked in: r8152(+) hid_logitech_hidpp
> > > uhid ccm
> 
> 
> Best Regards,
> Hayes
> 
> 

Best,
Ferenc