netdev - Re: [PATCH net-next 0/3] netlink: add variable-length / auto integers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce718606-df08-4249-b29d-6ec30a4c4648@6wind.com>
Date: Fri, 20 Oct 2023 09:24:18 +0200
From: Nicolas Dichtel <nicolas.dichtel@...nd.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH net-next 0/3] netlink: add variable-length / auto integers

Le 18/10/2023 à 23:39, Jakub Kicinski a écrit :
> Add netlink support for "common" / variable-length / auto integers
> which are carried at the message level as either 4B or 8B depending
> on the exact value. This saves space and will hopefully decrease
> the number of instances where we realize that we needed more bits
> after uAPI is set is stone. It also loosens the alignment requirements,
> avoiding the need for padding.
> 
> This mini-series is a fuller version of the previous RFC:
> https://lore.kernel.org/netdev/20121204.130914.1457976839967676240.davem@davemloft.net/
Probably https://lore.kernel.org/all/20231011003313.105315-1-kuba@kernel.org/ ;-)

Nicolas

> No user included here. I have tested (and will use) it
> in the upcoming page pool API but the assumption is that
> it will be widely applicable. So sending without a user.
> 
> Jakub Kicinski (3):
>   tools: ynl-gen: make the mnl_type() method public
>   netlink: add variable-length / auto integers
>   netlink: specs: add support for auto-sized scalars
> 
>  Documentation/netlink/genetlink-c.yaml        |  3 +-
>  Documentation/netlink/genetlink-legacy.yaml   |  3 +-
>  Documentation/netlink/genetlink.yaml          |  3 +-
>  Documentation/userspace-api/netlink/specs.rst | 18 ++++-
>  include/net/netlink.h                         | 69 ++++++++++++++++++-
>  include/uapi/linux/netlink.h                  |  5 ++
>  lib/nlattr.c                                  | 22 ++++++
>  net/netlink/policy.c                          | 14 +++-
>  tools/net/ynl/lib/nlspec.py                   |  6 ++
>  tools/net/ynl/lib/ynl.c                       |  6 ++
>  tools/net/ynl/lib/ynl.h                       | 17 +++++
>  tools/net/ynl/lib/ynl.py                      | 14 ++++
>  tools/net/ynl/ynl-gen-c.py                    | 44 ++++++------
>  13 files changed, 192 insertions(+), 32 deletions(-)
>