netdev - Re: [PATCH net] iavf: initialize waitqueues before starting watchdog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231020165126.03bb9eff@kernel.org>
Date: Fri, 20 Oct 2023 16:51:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Michal Schmidt <mschmidt@...hat.com>
Cc: netdev@...r.kernel.org, Sudheer Mogilappagari
 <sudheer.mogilappagari@...el.com>, Jeff Kirsher
 <jeffrey.t.kirsher@...el.com>, Jesse Brandeburg
 <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>,
 intel-wired-lan@...ts.osuosl.org
Subject: Re: [PATCH net] iavf: initialize waitqueues before starting
 watchdog_task

On Thu, 19 Oct 2023 09:13:46 +0200 Michal Schmidt wrote:
> It is not safe to initialize the waitqueues after queueing the
> watchdog_task. It will be using them.
> 
> The chance of this causing a real problem is very small, because
> there will be some sleeping before any of the waitqueues get used.
> I got a crash only after inserting an artificial sleep in iavf_probe.
> 
> Queue the watchdog_task as the last step in iavf_probe. Add a comment to
> prevent repeating the mistake.

Applied as 7db31110438 in net, thanks!