lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <f7b625af-64aa-42db-9b9c-95c0125564ee@proton.me> Date: Sat, 21 Oct 2023 07:21:07 +0000 From: Benno Lossin <benno.lossin@...ton.me> To: FUJITA Tomonori <fujita.tomonori@...il.com> Cc: netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, andrew@...n.ch, miguel.ojeda.sandonis@...il.com, tmgross@...ch.edu, boqun.feng@...il.com, wedsonaf@...il.com, greg@...ah.com Subject: Re: [PATCH net-next v5 1/5] rust: core abstractions for network PHY drivers On 19.10.23 23:51, FUJITA Tomonori wrote: > On Thu, 19 Oct 2023 16:37:46 +0000 > Benno Lossin <benno.lossin@...ton.me> wrote: > >> On 19.10.23 17:32, FUJITA Tomonori wrote: >>>> You can just do this (I omitted the `::kernel::` prefix for >>>> readability, if you add this in the macro, please include it): >>>> >>>> // CAST: `DriverVTable` is `repr(transparent)` and wrapping `bindings::phy_driver`. >>>> let ptr = drv.as_mut_ptr().cast::<bindings::phy_driver>(); >>>> let len = drv.len().try_into()?; >>>> // SAFETY: ... >>>> to_result(unsafe { bindings::phy_drivers_register(ptr, len, module.0) })?; >>>> >>>>> })?; >>> >>> The above solves DriverVTable.0 but still the macro can't access to >>> kernel::ThisModule.0. I got the following error: >> >> I think we could just provide an `as_ptr` getter function >> for `ThisModule`. But need to check with the others. >> > > ThisModule.0 is *mut bindings::module. Drivers should not use > bindings? This is a special case, since it `module` is used on a lot of functions (and it does not make sense to provide abstractions for those on `ThisModule`). Additionally, `ThisModule` already has a public `from_raw` function that takes a `*mut bindings::module`. If you add a `as_ptr` function, please create a separate patch for it. -- Cheers, Benno
Powered by blists - more mailing lists