lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZTO0qBkkSJGauYlU@nanopsycho> Date: Sat, 21 Oct 2023 13:23:20 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <kuba@...nel.org> Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com, amritha.nambiar@...el.com, donald.hunter@...il.com, chuck.lever@...cle.com, sdf@...gle.com Subject: Re: [PATCH net-next] tools: ynl-gen: change spacing around __attribute__ Sat, Oct 21, 2023 at 12:18:27AM CEST, kuba@...nel.org wrote: >checkpatch gets confused and treats __attribute__ as a function call. >It complains about white space before "(": > >WARNING:SPACING: space prohibited between function name and open parenthesis '(' >+ struct netdev_queue_get_rsp obj __attribute__ ((aligned (8))); > >No spaces wins in the kernel: > > $ git grep 'attribute__((.*aligned(' | wc -l > 480 > $ git grep 'attribute__ ((.*aligned (' | wc -l > 110 > $ git grep 'attribute__ ((.*aligned(' | wc -l > 94 > $ git grep 'attribute__((.*aligned (' | wc -l > 63 > >So, whatever, change the codegen. > >Note that checkpatch also thinks we should use __aligned(), >but this is user space code. > >Link: https://lore.kernel.org/all/202310190900.9Dzgkbev-lkp@intel.com/ >Signed-off-by: Jakub Kicinski <kuba@...nel.org> Reviewed-by: Jiri Pirko <jiri@...dia.com>
Powered by blists - more mailing lists