netdev - Re: [PATCH v1] tcp: fix wrong RTO timeout when received SACK reneging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 22 Oct 2023 10:50:24 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Fred Chen <fred.chenchen03@...il.com>
Cc: edumazet@...gle.com, davem@...emloft.net, netdev@...r.kernel.org,
 yangpc@...gsu.com, ycheng@...gle.com, ncardwell@...gle.com
Subject: Re: [PATCH v1] tcp: fix wrong RTO timeout when received SACK reneging

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@...emloft.net>:

On Sat, 21 Oct 2023 08:19:47 +0800 you wrote:
> This commit fix wrong RTO timeout when received SACK reneging.
> 
> When an ACK arrived pointing to a SACK reneging, tcp_check_sack_reneging()
> will rearm the RTO timer for min(1/2*srtt, 10ms) into to the future.
> 
> But since the commit 62d9f1a6945b ("tcp: fix TLP timer not set when
> CA_STATE changes from DISORDER to OPEN") merged, the tcp_set_xmit_timer()
> is moved after tcp_fastretrans_alert()(which do the SACK reneging check),
> so the RTO timeout will be overwrited by tcp_set_xmit_timer() with
> icsk_rto instead of 1/2*srtt.
> 
> [...]

Here is the summary with links:
  - [v1] tcp: fix wrong RTO timeout when received SACK reneging
    https://git.kernel.org/netdev/net/c/d2a0fc372aca

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html