netdev - Re: [PATCH net-next 2/8] bnxt_en: Fix invoking hwmon_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5e209398-3262-da47-1f6c-aa6fdab8a22f@roeck-us.net>
Date: Sun, 22 Oct 2023 08:52:13 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Michael Chan <michael.chan@...adcom.com>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, gospo@...adcom.com, kalesh-anakkur.purayil@...adcom.com,
 Kashyap Desai <kashyap.desai@...adcom.com>,
 Somnath Kotur <somnath.kotur@...adcom.com>
Subject: Re: [PATCH net-next 2/8] bnxt_en: Fix invoking hwmon_notify_event

On 10/20/23 14:27, Michael Chan wrote:
> From: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> 
> FW sends the async event to the driver when the device temperature goes
> above or below the threshold values.  Only notify hwmon if the
> temperature is increasing to the next alert level, not when it is
> decreasing.
> 
> Cc: Guenter Roeck <linux@...ck-us.net>
> Reviewed-by: Kashyap Desai <kashyap.desai@...adcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@...adcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/net/ethernet/broadcom/bnxt/bnxt.c | 16 +++++++++++-----
>   1 file changed, 11 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> index 7837e22f237b..65092150d451 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
> @@ -2166,6 +2166,7 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2)
>   	case ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_THERMAL_THRESHOLD: {
>   		u32 type = EVENT_DATA1_THERMAL_THRESHOLD_TYPE(data1);
>   		char *threshold_type;
> +		bool notify = false;
>   		char *dir_str;
>   
>   		switch (type) {
> @@ -2185,18 +2186,23 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2)
>   			netdev_err(bp->dev, "Unknown Thermal threshold type event\n");
>   			return false;
>   		}
> -		if (EVENT_DATA1_THERMAL_THRESHOLD_DIR_INCREASING(data1))
> +		if (EVENT_DATA1_THERMAL_THRESHOLD_DIR_INCREASING(data1)) {
>   			dir_str = "above";
> -		else
> +			notify = true;
> +		} else {
>   			dir_str = "below";
> +		}
>   		netdev_warn(bp->dev, "Chip temperature has gone %s the %s thermal threshold!\n",
>   			    dir_str, threshold_type);
>   		netdev_warn(bp->dev, "Temperature (In Celsius), Current: %lu, threshold: %lu\n",
>   			    BNXT_EVENT_THERMAL_CURRENT_TEMP(data2),
>   			    BNXT_EVENT_THERMAL_THRESHOLD_TEMP(data2));
> -		bp->thermal_threshold_type = type;
> -		set_bit(BNXT_THERMAL_THRESHOLD_SP_EVENT, &bp->sp_event);
> -		return true;
> +		if (notify) {
> +			bp->thermal_threshold_type = type;
> +			set_bit(BNXT_THERMAL_THRESHOLD_SP_EVENT, &bp->sp_event);
> +			return true;
> +		}
> +		return false;
>   	}
>   	default:
>   		netdev_err(bp->dev, "FW reported unknown error type %u\n",