netdev - Re: [PATCH net-next v2 1/2] net: dsa: Use conduit and user terms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea6f739d-5195-41e4-a8e7-8300eebe9a86@broadcom.com>
Date: Mon, 23 Oct 2023 08:50:08 -0700
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Pavel Machek <pavel@....cz>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Florian Fainelli <f.fainelli@...il.com>, Vladimir Oltean
 <olteanv@...il.com>, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>,
 Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>,
 "open list:ARM/Mediatek SoC support" <linux-kernel@...r.kernel.org>,
 "moderated list:ARM/Mediatek SoC support"
 <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH net-next v2 1/2] net: dsa: Use conduit and user terms

Howdy,

On 10/23/2023 12:12 AM, Pavel Machek wrote:
> On Wed 2023-10-11 15:20:25, Florian Fainelli wrote:
>> Use more inclusive terms throughout the DSA subsystem by moving away
>> from "master" which is replaced by "conduit" and "slave" which is
>> replaced by "user". No functional changes.
> 
> Note that by making it more "inclusive" you make it incomprehensible
> for users where english is not their first language.

We have use the term conduit and user ports a lot while discussing DSA 
just never actually made that part of the code. From that angle, there 
are precedent and people more or less familiar with the subsystem should 
be able to retrain their muscle memory towards these concepts.

> 
> Plus, "user" already means something else in kernel context, so this
> will likely be confusing even for native speakers.

I am open to other suggestions that would make it easier to grasp as a 
subsystem, native speaker or else. The "user" ports are user-visible and 
controllable, seems quite apt.

> 
> This is wrong.

And I am afraid without more substance this is a gratuitous rejection of 
change. I am not engaging into why or why we should not be doing that 
effort.
-- 
Florian

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4221 bytes)