netdev - Re: [PATCH bpf-next v2 4/7] bpftool: Implement link show support for netkit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <813f501e-34b9-c46b-fc6f-1e927458a743@iogearbox.net>
Date: Mon, 23 Oct 2023 16:46:54 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Toke Høiland-Jørgensen <toke@...nel.org>,
 bpf@...r.kernel.org
Cc: netdev@...r.kernel.org, martin.lau@...ux.dev, razor@...ckwall.org,
 ast@...nel.org, andrii@...nel.org, john.fastabend@...il.com, sdf@...gle.com,
 Quentin Monnet <quentin@...valent.com>
Subject: Re: [PATCH bpf-next v2 4/7] bpftool: Implement link show support for
 netkit

On 10/23/23 4:26 PM, Toke Høiland-Jørgensen wrote:
> Daniel Borkmann <daniel@...earbox.net> writes:
> 
>> Add support to dump netkit link information to bpftool in similar way as
>> we have for XDP. The netkit link info only exposes the ifindex.
>>
>> Below shows an example link dump output, and a cgroup link is included for
>> comparison, too:
>>
>>    # bpftool link
>>    [...]
>>    10: cgroup  prog 2466
>>          cgroup_id 1  attach_type cgroup_inet6_post_bind
>>    [...]
>>    8: netkit  prog 35
>>          ifindex nk1(18)
>>    [...]
> 
> Couldn't we make this show whether the program is attached as
> primary/peer as well? Seems like that would be useful (like in the
> cgroup output above)?

Makes sense, will add it.

Thanks,
Daniel