netdev - Re: [PATCH net-next] tls: don't reset prot->aad_size and prot->tail_size for TLS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 23 Oct 2023 17:20:23 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Sabrina Dubroca <sd@...asysnail.net>
Cc: netdev@...r.kernel.org, davem@...emloft.net, borisp@...dia.com,
 edumazet@...gle.com, kuba@...nel.org, john.fastabend@...il.com,
 pabeni@...hat.com, horms@...nel.org, ttoukan.linux@...il.com
Subject: Re: [PATCH net-next] tls: don't reset prot->aad_size and prot->tail_size
 for TLS_HW

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 20 Oct 2023 16:00:55 +0200 you wrote:
> Prior to commit 1a074f7618e8 ("tls: also use init_prot_info in
> tls_set_device_offload"), setting TLS_HW on TX didn't touch
> prot->aad_size and prot->tail_size. They are set to 0 during context
> allocation (tls_prot_info is embedded in tls_context, kzalloc'd by
> tls_ctx_create).
> 
> When the RX key is configured, tls_set_sw_offload is called (for both
> TLS_SW and TLS_HW). If the TX key is configured in TLS_HW mode after
> the RX key has been installed, init_prot_info will now overwrite the
> correct values of aad_size and tail_size, breaking SW decryption and
> causing -EBADMSG errors to be returned to userspace.
> 
> [...]

Here is the summary with links:
  - [net-next] tls: don't reset prot->aad_size and prot->tail_size for TLS_HW
    https://git.kernel.org/netdev/net-next/c/b7c4f5730a9f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html