lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZTYc04N9VK7EarHY@nanopsycho> Date: Mon, 23 Oct 2023 09:12:19 +0200 From: Jiri Pirko <jiri@...nulli.us> To: David Ahern <dsahern@...nel.org> Cc: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@...il.com>, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, shuah@...nel.org, netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org, linux-kernel-mentees@...ts.linuxfoundation.org Subject: Re: [PATCH] selftests:net change ifconfig with ip command Sun, Oct 22, 2023 at 07:50:52PM CEST, dsahern@...nel.org wrote: >On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote: >> diff --git a/tools/testing/selftests/net/route_localnet.sh b/tools/testing/selftests/net/route_localnet.sh >> index 116bfeab72fa..3ab9beb4462c 100755 >> --- a/tools/testing/selftests/net/route_localnet.sh >> +++ b/tools/testing/selftests/net/route_localnet.sh >> @@ -18,8 +18,10 @@ setup() { >> ip route del 127.0.0.0/8 dev lo table local >> ip netns exec "${PEER_NS}" ip route del 127.0.0.0/8 dev lo table local >> >> - ifconfig veth0 127.25.3.4/24 up >> - ip netns exec "${PEER_NS}" ifconfig veth1 127.25.3.14/24 up >> + ip a add 127.25.3.4/24 dev veth0 > >ip addr add ... Why not "address" then? :) What's wrong with "a"? > >> + ip link set dev veth0 up >> + ip netns exec "${PEER_NS}" ip a add 127.25.3.14/24 dev veth1 > >ip addr add ... > >> + ip netns exec "${PEER_NS}" ip link set dev veth1 up >> >> ip route flush cache >> ip netns exec "${PEER_NS}" ip route flush cache > >
Powered by blists - more mailing lists