netdev - Re: [PATCH bpf-next v4 00/11] xsk: TX metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 23 Oct 2023 11:38:16 -0700
From: Stanislav Fomichev <sdf@...gle.com>
To: Magnus Karlsson <magnus.karlsson@...il.com>
Cc: bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net, 
	andrii@...nel.org, martin.lau@...ux.dev, song@...nel.org, yhs@...com, 
	john.fastabend@...il.com, kpsingh@...nel.org, haoluo@...gle.com, 
	jolsa@...nel.org, kuba@...nel.org, toke@...nel.org, willemb@...gle.com, 
	dsahern@...nel.org, magnus.karlsson@...el.com, bjorn@...nel.org, 
	maciej.fijalkowski@...el.com, hawk@...nel.org, yoong.siang.song@...el.com, 
	netdev@...r.kernel.org, xdp-hints@...-project.net
Subject: Re: [PATCH bpf-next v4 00/11] xsk: TX metadata

On 10/23, Magnus Karlsson wrote:
> On Thu, 19 Oct 2023 at 19:49, Stanislav Fomichev <sdf@...gle.com> wrote:
> >
> > This series implements initial TX metadata (offloads) for AF_XDP.
> > See patch #2 for the main implementation and mlx5/stmmac ones for the
> > example on how to consume the metadata on the device side.
> >
> > Starting with two types of offloads:
> > - request TX timestamp (and write it back into the metadata area)
> > - request TX checksum offload
> >
> > Changes since v3:
> > - fix xsk_tx_metadata_ops kdoc (Song Yoong Siang)
> > - add missing xsk_tx_metadata_to_compl for XDP_SOCKETS=n (Vinicius Costa Gomes and Intel bots)
> > - add reference timestamps to the selftests + refactor existing ones (Jesper)
> >
> > v3: https://lore.kernel.org/bpf/20231003200522.1914523-1-sdf@google.com/
> 
> Thanks for working on this Stanislav. I went through the patch set and
> it looks good to me. You have addressed all the feedback that Maciej
> and I had on a previous version. Just had some small things in two of
> the patches. Apart from that, you are good to go and you can add my
> ack to the next version.
> 
> Acked-by: Magnus Karlsson <magnus.karlsson@...el.com>
> 
> Again, really appreciate all your work with this!

Thank you! Appreciate the review and comments as well!