[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e59c4744-65b7-4dbe-ab63-1eac550a498e@intel.com>
Date: Mon, 23 Oct 2023 13:23:55 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Jiri Pirko <jiri@...nulli.us>, <netdev@...r.kernel.org>
CC: <kuba@...nel.org>, <pabeni@...hat.com>, <davem@...emloft.net>,
<edumazet@...gle.com>, <johannes@...solutions.net>
Subject: Re: [patch net-next v3 00/10] devlink: finish conversion to generated
split_ops
On 10/21/2023 4:27 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...dia.com>
>
> This patchset converts the remaining genetlink commands to generated
> split_ops and removes the existing small_ops arrays entirely
> alongside with shared netlink attribute policy.
>
> Patches #1-#6 are just small preparations and small fixes on multiple
> places. Note that couple of patches contain the "Fixes"
> tag but no need to put them into -net tree.
> Patch #7 is a simple rename preparation
> Patch #8 is the main one in this set and adds actual definitions of cmds
> in to yaml file.
> Patches #9-#10 finalize the change removing bits that are no longer in
> use.
>
> ---
Everything in this version looks good to me.
Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
> v2->v3:
> - just small fix and rebase in patch #2
> v1->v2:
> - see individual patches for changelog
> - patch #3 is new
> - patch "netlink: specs: devlink: fix reply command values" was removed
> from the set and sent separately to -net
>
> Jiri Pirko (10):
> genetlink: don't merge dumpit split op for different cmds into single
> iter
> tools: ynl-gen: introduce support for bitfield32 attribute type
> tools: ynl-gen: render rsp_parse() helpers if cmd has only dump op
> netlink: specs: devlink: remove reload-action from devlink-get cmd
> reply
> netlink: specs: devlink: make dont-validate single line
> devlink: make devlink_flash_overwrite enum named one
> devlink: rename netlink callback to be aligned with the generated ones
> netlink: specs: devlink: add the remaining command to generate
> complete split_ops
> devlink: remove duplicated netlink callback prototypes
> devlink: remove netlink small_ops
>
> Documentation/netlink/genetlink-legacy.yaml | 2 +-
> Documentation/netlink/specs/devlink.yaml | 1604 +++++-
> .../netlink/genetlink-legacy.rst | 2 +-
> include/uapi/linux/devlink.h | 2 +-
> net/devlink/dev.c | 10 +-
> net/devlink/devl_internal.h | 64 -
> net/devlink/dpipe.c | 14 +-
> net/devlink/health.c | 24 +-
> net/devlink/linecard.c | 3 +-
> net/devlink/netlink.c | 328 +-
> net/devlink/netlink_gen.c | 757 ++-
> net/devlink/netlink_gen.h | 64 +-
> net/devlink/param.c | 14 +-
> net/devlink/port.c | 11 +-
> net/devlink/rate.c | 6 +-
> net/devlink/region.c | 8 +-
> net/devlink/resource.c | 4 +-
> net/devlink/sb.c | 17 +-
> net/devlink/trap.c | 9 +-
> net/netlink/genetlink.c | 3 +-
> tools/net/ynl/generated/devlink-user.c | 5075 +++++++++++++++--
> tools/net/ynl/generated/devlink-user.h | 4213 ++++++++++++--
> tools/net/ynl/lib/ynl.c | 6 +
> tools/net/ynl/lib/ynl.h | 1 +
> tools/net/ynl/lib/ynl.py | 13 +-
> tools/net/ynl/ynl-gen-c.py | 50 +-
> 26 files changed, 10644 insertions(+), 1660 deletions(-)
>
Powered by blists - more mailing lists