netdev - Re: [PATCH net-next v6 12/16] net: Replace hwtstamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231023095641.75dd89c6@kmaincent-XPS-13-7390>
Date: Mon, 23 Oct 2023 09:56:41 +0200
From: Köry Maincent <kory.maincent@...tlin.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn
 <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
 <linux@...linux.org.uk>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Richard
 Cochran <richardcochran@...il.com>, Radu Pirea
 <radu-nicolae.pirea@....nxp.com>, Jay Vosburgh <j.vosburgh@...il.com>, Andy
 Gospodarek <andy@...yhouse.net>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>, Claudiu Beznea <claudiu.beznea@...on.dev>,
 Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jonathan Corbet
 <corbet@....net>, Horatiu Vultur <horatiu.vultur@...rochip.com>,
 UNGLinuxDriver@...rochip.com, Simon Horman <horms@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, Maxime Chevallier
 <maxime.chevallier@...tlin.com>
Subject: Re: [PATCH net-next v6 12/16] net: Replace hwtstamp_source by
 timestamping layer

On Fri, 20 Oct 2023 18:47:14 -0700
Jakub Kicinski <kuba@...nel.org> wrote:

> On Thu, 19 Oct 2023 16:29:27 +0200 Kory Maincent wrote:
> > Replace hwtstamp_source which is only used by the kernel_hwtstamp_config
> > structure by the more widely use timestamp_layer structure. This is done
> > to prepare the support of selectable timestamping source.
> > 
> > Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>  
> 
> Temporarily breaks the build :(
> 
> net/core/dev_ioctl.c:335:44: error: use of undeclared identifier
> 'NET_TIMESTAMPING'; did you mean 'NO_TIMESTAMPING'? cfg->source = phy_ts ?
> PHY_TIMESTAMPING : NET_TIMESTAMPING; ^~~~~~~~~~~~~~~~
>                                                   NO_TIMESTAMPING
> include/uapi/linux/net_tstamp.h:18:2: note: 'NO_TIMESTAMPING' declared here
>         NO_TIMESTAMPING,
>         ^

Doh, I forgot to run the in-between patch build procedures. Sorry about that.

Köry