lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <MW4PR11MB57763BDD2770028003988D8AFDD8A@MW4PR11MB5776.namprd11.prod.outlook.com> Date: Mon, 23 Oct 2023 09:01:40 +0000 From: "Drewek, Wojciech" <wojciech.drewek@...el.com> To: Edward AD <twuufnxlz@...il.com>, "syzbot+9704e6f099d952508943@...kaller.appspotmail.com" <syzbot+9704e6f099d952508943@...kaller.appspotmail.com> CC: "davem@...emloft.net" <davem@...emloft.net>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "reibax@...il.com" <reibax@...il.com>, "richardcochran@...il.com" <richardcochran@...il.com>, "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com> Subject: RE: [PATCH] ptp: ptp_read should not release queue > -----Original Message----- > From: Edward AD <twuufnxlz@...il.com> > Sent: Monday, October 23, 2023 4:46 AM > To: syzbot+9704e6f099d952508943@...kaller.appspotmail.com > Cc: davem@...emloft.net; linux-kernel@...r.kernel.org; netdev@...r.kernel.org; reibax@...il.com; richardcochran@...il.com; > syzkaller-bugs@...glegroups.com > Subject: [PATCH] ptp: ptp_read should not release queue > > Firstly, queue is not the memory allocated in ptp_read; > Secondly, other processes may block at ptp_read and wait for conditions to be > met to perform read operations. > > Reported-and-tested-by: syzbot+9704e6f099d952508943@...kaller.appspotmail.com > Fixes: 8f5de6fb2453 ("ptp: support multiple timestamp event readers") > Signed-off-by: Edward AD <twuufnxlz@...il.com> Hi Edward, Consider adding a target to the subject: [PATCH net] in this case > --- > drivers/ptp/ptp_chardev.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c > index 282cd7d24077..27c1ef493617 100644 > --- a/drivers/ptp/ptp_chardev.c > +++ b/drivers/ptp/ptp_chardev.c > @@ -585,7 +585,5 @@ ssize_t ptp_read(struct posix_clock_context *pccontext, uint rdflags, > free_event: > kfree(event); > exit: > - if (result < 0) > - ptp_release(pccontext); > return result; > } > -- > 2.25.1 >
Powered by blists - more mailing lists