lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231023230826.531858-6-jacob.e.keller@intel.com> Date: Mon, 23 Oct 2023 16:08:21 -0700 From: Jacob Keller <jacob.e.keller@...el.com> To: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: Michal Schmidt <mschmidt@...hat.com>, Wojciech Drewek <wojciech.drewek@...el.com>, Rafal Romanowski <rafal.romanowski@...el.com>, Jacob Keller <jacob.e.keller@...el.com> Subject: [PATCH net-next 4/9] iavf: in iavf_down, disable queues when removing the driver From: Michal Schmidt <mschmidt@...hat.com> In iavf_down, we're skipping the scheduling of certain operations if the driver is being removed. However, the IAVF_FLAG_AQ_DISABLE_QUEUES request must not be skipped in this case, because iavf_close waits for the transition to the __IAVF_DOWN state, which happens in iavf_virtchnl_completion after the queues are released. Without this fix, "rmmod iavf" takes half a second per interface that's up and prints the "Device resources not yet released" warning. Fixes: c8de44b577eb ("iavf: do not process adminq tasks when __IAVF_IN_REMOVE_TASK is set") Signed-off-by: Michal Schmidt <mschmidt@...hat.com> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com> Tested-by: Rafal Romanowski <rafal.romanowski@...el.com> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> --- drivers/net/ethernet/intel/iavf/iavf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index b30d703e26a1..7ca19dfea109 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -1440,9 +1440,9 @@ void iavf_down(struct iavf_adapter *adapter) adapter->aq_required |= IAVF_FLAG_AQ_DEL_FDIR_FILTER; if (!list_empty(&adapter->adv_rss_list_head)) adapter->aq_required |= IAVF_FLAG_AQ_DEL_ADV_RSS_CFG; - adapter->aq_required |= IAVF_FLAG_AQ_DISABLE_QUEUES; } + adapter->aq_required |= IAVF_FLAG_AQ_DISABLE_QUEUES; mod_delayed_work(adapter->wq, &adapter->watchdog_task, 0); } -- 2.41.0
Powered by blists - more mailing lists