netdev - Re: [PATCH ipsec-next] xfrm Fix use after free in __xfrm6_udp_encap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZTeerJZ6Js393ZEs@gauss3.secunet.de>
Date: Tue, 24 Oct 2023 12:38:36 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: <netdev@...r.kernel.org>
CC: Antony Antony <antony.antony@...unet.com>, Dan Carpenter
	<dan.carpenter@...aro.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH ipsec-next] xfrm Fix use after free in
 __xfrm6_udp_encap_rcv.

On Fri, Oct 20, 2023 at 10:05:55AM +0200, Steffen Klassert wrote:
> A recent patch changed xfrm6_udp_encap_rcv to not
> free the skb itself anymore but fogot the case
> where xfrm4_udp_encap_rcv is called subsequently.
> 
> Fix this by moving the call to xfrm4_udp_encap_rcv
> from __xfrm6_udp_encap_rcv to xfrm6_udp_encap_rcv.
> 
> Fixes: 221ddb723d90 ("xfrm: Support GRO for IPv6 ESP in UDP encapsulation")
> Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>

Now applied to ipsec-next.