lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20231023230826.531858-9-jacob.e.keller@intel.com> Date: Mon, 23 Oct 2023 16:08:24 -0700 From: Jacob Keller <jacob.e.keller@...el.com> To: netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org> Cc: Michal Schmidt <mschmidt@...hat.com>, Wojciech Drewek <wojciech.drewek@...el.com>, Jacob Keller <jacob.e.keller@...el.com> Subject: [PATCH net-next 7/9] iavf: use unregister_netdev From: Michal Schmidt <mschmidt@...hat.com> Use unregister_netdev, which takes rtnl_lock for us. We don't have to check the reg_state under rtnl_lock. There's nothing to race with. We have just cancelled the finish_config work. Signed-off-by: Michal Schmidt <mschmidt@...hat.com> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com> Reviewed-by: Jacob Keller <jacob.e.keller@...el.com> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> --- drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c index 6e93e73385b3..85252b9dce50 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_main.c +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c @@ -5166,10 +5166,8 @@ static void iavf_remove(struct pci_dev *pdev) cancel_delayed_work_sync(&adapter->watchdog_task); cancel_work_sync(&adapter->finish_config); - rtnl_lock(); if (netdev->reg_state == NETREG_REGISTERED) - unregister_netdevice(netdev); - rtnl_unlock(); + unregister_netdev(netdev); if (CLIENT_ALLOWED(adapter)) { err = iavf_lan_del_device(adapter); -- 2.41.0
Powered by blists - more mailing lists