lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <ZTe/7nfMmS+6KhrE@nanopsycho> Date: Tue, 24 Oct 2023 15:00:30 +0200 From: Jiri Pirko <jiri@...nulli.us> To: Ivan Vecera <ivecera@...hat.com> Cc: netdev@...r.kernel.org, Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen <anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, intel-wired-lan@...ts.osuosl.org, linux-kernel@...r.kernel.org, Jacob Keller <jacob.e.keller@...el.com> Subject: Re: [PATCH net-next 1/2] i40e: Do not call devlink_port_type_clear() Tue, Oct 24, 2023 at 02:51:08PM CEST, ivecera@...hat.com wrote: >Do not call devlink_port_type_clear() prior devlink port unregister >and let devlink core to take care about it. > >Reproducer: >[root@...t ~]# rmmod i40e >[ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel? >[ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel? > >Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") >Signed-off-by: Ivan Vecera <ivecera@...hat.com> Ivan, I see that even if we have checks and warnings, it is not enough :) Reviewed-by: Jiri Pirko <jiri@...dia.com> Btw, some (even brief) cover letter for patchset would be nice.
Powered by blists - more mailing lists