netdev - Re: [PATCH v17 02/20] netlink: add new family to manage ULP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024075908.68730358@kernel.org>
Date: Tue, 24 Oct 2023 07:59:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jiri Pirko <jiri@...nulli.us>
Cc: Aurelien Aptel <aaptel@...dia.com>, linux-nvme@...ts.infradead.org,
 netdev@...r.kernel.org, sagi@...mberg.me, hch@....de, kbusch@...nel.org,
 axboe@...com, chaitanyak@...dia.com, davem@...emloft.net,
 aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
 ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
 galshalom@...dia.com, mgurtovoy@...dia.com, edumazet@...gle.com,
 pabeni@...hat.com, imagedong@...cent.com
Subject: Re: [PATCH v17 02/20] netlink: add new family to manage ULP_DDP
 enablement and stats

On Tue, 24 Oct 2023 15:58:22 +0200 Jiri Pirko wrote:
> >+definitions:
> >+  -
> >+    type: enum
> >+    name: cap
> >+    entries:
> >+      - nvme-tcp
> >+      - nvme-tcp-ddgst-rx
> >+
> >+uapi-header: linux/ulp_ddp_nl.h  
> 
> Not needed.
> Hmm, Jakub, why this is not only allowed in genetlink-legacy?

Agreed that it's not needed here.
There's a non-trivial chance of name collisions between new families 
and existing headers under include/uapi/linux. Since this is a C/C++
-only artifact and "modern" languages will simply ignore it allowing it
seemed like the right choice.

> >+      -
> >+        name: pad
> >+        type: pad
> >+      -
> >+        name: rx-nvmeotcp-sk-add
> >+        doc: Sockets successfully configured for NVMeTCP offloading.
> >+        type: u64

Everything you have as u64 should now be uint, and pads can then go
away.