netdev - Re: [PATCH net-next v7 2/7] dt-bindings: net: mvusb: Fix up DSA example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4df5ef7e-d3dd-45a7-8edb-182784167243@gmail.com>
Date: Tue, 24 Oct 2023 09:34:43 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Linus Walleij <linus.walleij@...aro.org>, Andrew Lunn <andrew@...n.ch>,
 Gregory Clement <gregory.clement@...tlin.com>,
 Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
 Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Russell King <linux@...linux.org.uk>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Marek Behún <kabel@...nel.org>
Cc: Christian Marangi <ansuelsmth@...il.com>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 Vladimir Oltean <vladimir.oltean@....com>, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH net-next v7 2/7] dt-bindings: net: mvusb: Fix up DSA
 example

On 10/24/23 06:20, Linus Walleij wrote:
> When adding a proper schema for the Marvell mx88e6xxx switch,
> the scripts start complaining about this embedded example:
> 
>    dtschema/dtc warnings/errors:
>    net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells'
>    is a required property
>    from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
>    net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells'
>    is a required property
>    from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
> 
> Fix this up by extending the example with those properties in
> the ports node.
> 
> While we are at it, rename "ports" to "ethernet-ports" and rename
> "switch" to "ethernet-switch" as this is recommended practice.
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@....com>
> Reviewed-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian