lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <97e1f76a-3505-4783-838a-10b9cacee8bd@intel.com> Date: Mon, 23 Oct 2023 17:14:17 -0700 From: Jacob Keller <jacob.e.keller@...el.com> To: Adam Ford <aford173@...il.com>, <netdev@...r.kernel.org> CC: <aford@...conembedded.com>, Andrew Lunn <andrew@...n.ch>, "Grygorii Strashko" <grygorii.strashko@...com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo Abeni" <pabeni@...hat.com>, <linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH V2] net: ethernet: davinci_emac: Use MAC Address from Device Tree On 10/22/2023 8:19 AM, Adam Ford wrote: > Currently there is a device tree entry called "local-mac-address" > which can be filled by the bootloader or manually set.This is > useful when the user does not want to use the MAC address > programmed into the SoC. > > Currently, the davinci_emac reads the MAC from the DT, copies > it from pdata->mac_addr to priv->mac_addr, then blindly overwrites > it by reading from registers in the SoC, and falls back to a > random MAC if it's still not valid. This completely ignores any > MAC address in the device tree. > > In order to use the local-mac-address, check to see if the contents > of priv->mac_addr are valid before falling back to reading from the > SoC when the MAC address is not valid. > > Signed-off-by: Adam Ford <aford173@...il.com> > Reviewed-by: Andrew Lunn <andrew@...n.ch> > --- > V2: Rebase, add R-B tag, and post stand-alone for netdev branch, since > the device tree patch has already been accepted via the omap tree. Looks like you didn't add the tag for which tree. Given the context, I would assume net-next. Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>
Powered by blists - more mailing lists