netdev - Re: [PATCH net-next v2 0/6] net: deduplicate netdev name allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 24 Oct 2023 20:10:27 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, johannes.berg@...el.com, mpe@...erman.id.au, j@...fi,
 jiri@...nulli.us
Subject: Re: [PATCH net-next v2 0/6] net: deduplicate netdev name allocation

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 23 Oct 2023 08:23:40 -0700 you wrote:
> After recent fixes we have even more duplicated code in netdev name
> allocation helpers. There are two complications in this code.
> First, __dev_alloc_name() clobbers its output arg even if allocation
> fails, forcing callers to do extra copies. Second as our experience in
> commit 55a5ec9b7710 ("Revert "net: core: dev_get_valid_name is now the same as dev_alloc_name_ns"") and
> commit 029b6d140550 ("Revert "net: core: maybe return -EEXIST in __dev_alloc_name"")
> taught us, user space is very sensitive to the exact error codes.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/6] net: don't use input buffer of __dev_alloc_name() as a scratch space
    https://git.kernel.org/netdev/net-next/c/bd07063dd11f
  - [net-next,v2,2/6] net: make dev_alloc_name() call dev_prep_valid_name()
    https://git.kernel.org/netdev/net-next/c/556c755a4d81
  - [net-next,v2,3/6] net: reduce indentation of __dev_alloc_name()
    https://git.kernel.org/netdev/net-next/c/9a810468126c
  - [net-next,v2,4/6] net: trust the bitmap in __dev_alloc_name()
    https://git.kernel.org/netdev/net-next/c/7ad17b04dc7b
  - [net-next,v2,5/6] net: remove dev_valid_name() check from __dev_alloc_name()
    https://git.kernel.org/netdev/net-next/c/70e1b14c1bcb
  - [net-next,v2,6/6] net: remove else after return in dev_prep_valid_name()
    https://git.kernel.org/netdev/net-next/c/ce4cfa2318af

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html