netdev - Re: [PATCH net-next] net: ethernet: mtk_wed: fix firmware loading for MT7986 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e9cf19b-9f04-4356-8d69-0d8a4cd9e087@intel.com>
Date: Mon, 23 Oct 2023 17:44:09 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>, <netdev@...r.kernel.org>
CC: <lorenzo.bianconi@...hat.com>, <nbd@....name>, <john@...ozen.org>,
	<sean.wang@...iatek.com>, <Mark-MC.Lee@...iatek.com>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<frank-w@...lic-files.de>, <daniel@...rotopia.org>
Subject: Re: [PATCH net-next] net: ethernet: mtk_wed: fix firmware loading for
 MT7986 SoC



On 10/23/2023 3:00 PM, Lorenzo Bianconi wrote:
> The WED mcu firmware does not contain all the memory regions defined in
> the dts reserved_memory node (e.g. MT7986 WED firmware does not contain
> cpu-boot region).
> Reverse the mtk_wed_mcu_run_firmware() logic to check all the fw
> sections are defined in the dts reserved_memory node.
> 
> Fixes: c6d961aeaa77 ("net: ethernet: mtk_wed: move mem_region array out of mtk_wed_mcu_load_firmware")
> Tested-by: Frank Wunderlich <frank-w@...lic-files.de>
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> ---

Reviewed-by: Jacob Keller

As a sidenote, this was rather difficult to read in patch format,
because the diff is minized to keep some of the meaningless lines as
not-changed including line breaks and }.

I applied it and reviewed by comparing the previous and current versions.