netdev - Re: [PATCH v5 3/8] r8152: Cancel hw_phy_work if we have an error in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ced1531b-ba67-4302-8bfa-3003219582e5@gmail.com>
Date: Mon, 23 Oct 2023 18:24:52 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Douglas Anderson <dianders@...omium.org>, Jakub Kicinski
 <kuba@...nel.org>, Hayes Wang <hayeswang@...ltek.com>,
 "David S . Miller" <davem@...emloft.net>
Cc: Edward Hill <ecgh@...omium.org>, Laura Nao <laura.nao@...labora.com>,
 Alan Stern <stern@...land.harvard.edu>, Simon Horman <horms@...nel.org>,
 linux-usb@...r.kernel.org, Grant Grundler <grundler@...omium.org>,
 Bjørn Mork <bjorn@...k.no>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v5 3/8] r8152: Cancel hw_phy_work if we have an error in
 probe

On 10/20/2023 2:06 PM, Douglas Anderson wrote:
> The error handling in rtl8152_probe() is missing a call to cancel the
> hw_phy_work. Add it in to match what's in the cleanup code in
> rtl8152_disconnect().
> 
> Fixes: a028a9e003f2 ("r8152: move the settings of PHY to a work queue")
> Signed-off-by: Douglas Anderson <dianders@...omium.org>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian