netdev - Re: [PATCH net-next v2 1/4] net: ipv6/addrconf: clamp preferred

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTkIwIFKXe9aEkY4@nanopsycho>
Date: Wed, 25 Oct 2023 14:23:28 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Alex Henrie <alexhenrie24@...il.com>
Cc: netdev@...r.kernel.org, jbohac@...e.cz, benoit.boissinot@...-lyon.org,
	davem@...emloft.net, hideaki.yoshifuji@...aclelinux.com,
	dsahern@...nel.org, pabeni@...hat.com, kuba@...nel.org
Subject: Re: [PATCH net-next v2 1/4] net: ipv6/addrconf: clamp preferred_lft
 to the maximum allowed

Tue, Oct 24, 2023 at 11:23:07PM CEST, alexhenrie24@...il.com wrote:
>Without this patch, there is nothing to stop the preferred lifetime of a
>temporary address from being greater than its valid lifetime. If that
>was the case, the valid lifetime was effectively ignored.
>

Sounds like a bugfix, correct? In that case, could you please
provide a proper Fixes tag and target -net tree?


>Signed-off-by: Alex Henrie <alexhenrie24@...il.com>
>---
> net/ipv6/addrconf.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
>index c2d471ad7922..26aedaab3647 100644
>--- a/net/ipv6/addrconf.c
>+++ b/net/ipv6/addrconf.c
>@@ -1399,6 +1399,7 @@ static int ipv6_create_tempaddr(struct inet6_ifaddr *ifp, bool block)
> 			      idev->cnf.temp_valid_lft + age);
> 	cfg.preferred_lft = cnf_temp_preferred_lft + age - idev->desync_factor;
> 	cfg.preferred_lft = min_t(__u32, ifp->prefered_lft, cfg.preferred_lft);
>+	cfg.preferred_lft = min_t(__u32, cfg.valid_lft, cfg.preferred_lft);
> 
> 	cfg.plen = ifp->prefix_len;
> 	tmp_tstamp = ifp->tstamp;
>-- 
>2.42.0
>
>