netdev - Re: [PATCH net-next 1/9] mptcp: add a new sysctl for make after break timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bfd0a37b09540fd3cf4107f9bea1b9efb70d5b33.camel@redhat.com>
Date: Wed, 25 Oct 2023 15:48:08 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>, Mat Martineau <martineau@...nel.org>
Cc: Matthieu Baerts <matttbe@...nel.org>, "David S. Miller"
	 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	netdev@...r.kernel.org, mptcp@...ts.linux.dev
Subject: Re: [PATCH net-next 1/9] mptcp: add a new sysctl for make after
 break timeout

On Tue, 2023-10-24 at 17:54 -0700, Jakub Kicinski wrote:
> On Mon, 23 Oct 2023 13:44:34 -0700 Mat Martineau wrote:
> > +		.procname = "close_timeout",
> > +		.maxlen = sizeof(unsigned int),
> > +		.mode = 0644,
> > +		.proc_handler = proc_dointvec_jiffies,
> 
> Silly question - proc_dointvec_jiffies() works fine for unsigned types?

AFAICS, yes: proc_dointvec_jiffies() internally uses
__do_proc_dointvec(), which parses the buffer to a 'long' local
variable and then do_proc_dointvec_jiffies_conv() converts it to
integer taking care of possible overflows.

Cheers,

Paolo