netdev - Re: [PATCH net-next v8 0/7] Add MACsec support for TJA11XX C45 PHYs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 25 Oct 2023 19:21:24 +0300
From: "Radu Pirea (OSS)" <radu-nicolae.pirea@....nxp.com>
To: sd@...asysnail.net, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, andrew@...n.ch, hkallweit1@...il.com,
 linux@...linux.org.uk, richardcochran@...il.com
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 sebastian.tobuschat@....nxp.com
Subject: Re: [PATCH net-next v8 0/7] Add MACsec support for TJA11XX C45 PHYs

Hi,

The state of this patch series was set to "Changes Requested", but no 
change was requested in V8 and I addressed the changes requested in V7. 
Am I missing something or is it a mistake?

On 23.10.2023 12:43, Radu Pirea (NXP OSS) wrote:
> This is the MACsec support for TJA11XX PHYs. The MACsec block encrypts
> the ethernet frames on the fly and has no buffering. This operation will
> grow the frames by 32 bytes. If the frames are sent back to back, the
> MACsec block will not have enough room to insert the SecTAG and the ICV
> and the frames will be dropped.
> 
> To mitigate this, the PHY can parse a specific ethertype with some
> padding bytes and replace them with the SecTAG and ICV. These padding
> bytes might be dummy or might contain information about TX SC that must
> be used to encrypt the frame.
> 
> Radu P.
> 
> Radu Pirea (NXP OSS) (7):
>    net: macsec: move sci_to_cpu to macsec header
>    net: macsec: documentation for macsec_context and macsec_ops
>    net: macsec: revert the MAC address if mdo_upd_secy fails
>    net: macsec: introduce mdo_insert_tx_tag
>    net: phy: nxp-c45-tja11xx: add MACsec support
>    net: phy: nxp-c45-tja11xx: add MACsec statistics
>    net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag
> 
>   MAINTAINERS                              |    2 +-
>   drivers/net/macsec.c                     |  130 +-
>   drivers/net/netdevsim/macsec.c           |    5 -
>   drivers/net/phy/Kconfig                  |    2 +-
>   drivers/net/phy/Makefile                 |    6 +-
>   drivers/net/phy/nxp-c45-tja11xx-macsec.c | 1724 ++++++++++++++++++++++
>   drivers/net/phy/nxp-c45-tja11xx.c        |   77 +-
>   drivers/net/phy/nxp-c45-tja11xx.h        |   62 +
>   include/net/macsec.h                     |   54 +
>   9 files changed, 2011 insertions(+), 51 deletions(-)
>   create mode 100644 drivers/net/phy/nxp-c45-tja11xx-macsec.c
>   create mode 100644 drivers/net/phy/nxp-c45-tja11xx.h
> 

-- 
Radu P.