netdev - Re: [PATCH net-next v2 5/7] uapi: mptcp: use header file generated from YAML spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 25 Oct 2023 18:40:52 +0200
From: Davide Caratti <dcaratti@...hat.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Mat Martineau <martineau@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Matthieu Baerts <matttbe@...nel.org>, netdev@...r.kernel.org, mptcp@...ts.linux.dev, 
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v2 5/7] uapi: mptcp: use header file generated
 from YAML spec

hello,

thanks for looking at this.

On Tue, Oct 24, 2023 at 10:00 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> > On Mon, 23 Oct 2023 11:17:09 -0700 Mat Martineau wrote:
> >> +/* for backward compatibility */
> >> +#define     __MPTCP_PM_CMD_AFTER_LAST       __MPTCP_PM_CMD_MAX
> >> +#define     __MPTCP_ATTR_AFTER_LAST         __MPTCP_ATTR_MAX
> >
> > Do you want to intentionally move to the normal naming or would you
> > prefer to keep the old names?

given that nobody should use them, I'd prefer to move to the normal
naming and drop the old definitions (_MPTCP_PM_CMD_AFTER_LAST and
__MPTCP_ATTR_AFTER_LAST). I was unsure if I could do the drop thing
actually, because applications using them would break the build then _
hence these two "backward compatibility" lines.

For the operation list, I see it's about exposing

cmd-cnt-name

to [ge]netlink*.yaml, and then do:

  9 max-by-define: true
 10 kernel-policy: per-op
 11 cmd-cnt-name: --mptcp-pm-cmd-after-last    <-- this
 12
 13 definitions:

the generated MPTCP #define(s) are the same as the ones we have in
net-next now: no need to specify __MPTCP_PM_CMD_MAX anymore.

For the attributes, I thought I could use  'attr-cnt-name' like:

169     name: attr
170     name-prefix: mptcp-pm-attr-
171     attr-cnt-name: --mptcp-attr-after-last <-- this
172     attributes:

as described in the [ge]netlink schema, but the tool seems to just ignore it.
-- 
davide





On Wed, Oct 25, 2023 at 1:49 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 24 Oct 2023 16:30:27 -0700 (PDT) Mat Martineau wrote:
> > I'm not sure if you're offering to add the feature or are asking us (well,
> > Davide) to implement it :)
>
> Either way is fine, Davide seems to have tackled the extensions in patches
> 1 and 2, so he may want to do it himself. Otherwise I'm more than happy
> to type and send the patch :)
>

> Let's make sure we update documentation, tho, in this case:
> Documentation/userspace-api/netlink/c-code-gen.rst
>