netdev - Re: [net-next PATCH v6 06/10] netdev-genl: Add netlink framework functions for napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231024153941.4c05da4b@kernel.org>
Date: Tue, 24 Oct 2023 15:39:41 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Amritha Nambiar <amritha.nambiar@...el.com>
Cc: netdev@...r.kernel.org, pabeni@...hat.com, sridhar.samudrala@...el.com
Subject: Re: [net-next PATCH v6 06/10] netdev-genl: Add netlink framework
 functions for napi

On Mon, 23 Oct 2023 18:33:50 -0700 Amritha Nambiar wrote:
> +	rcu_read_lock();
> +
> +	napi = napi_by_id(napi_id);
> +	if (napi)
> +		err = netdev_nl_napi_fill_one(rsp, napi, info);
> +	else
> +		err = -EINVAL;
> +
> +	rcu_read_unlock();

Is rcu_read_lock always going to be sufficient here?
Reading of the thread, for example, without much locking could
potentially get problematic.