netdev - Re: [pull request][net-next V2 00/15] mlx5 updates 2023-10-19

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 25 Oct 2023 11:52:02 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Saeed Mahameed <saeed@...nel.org>,
	"David S. Miller" <davem@...emloft.net>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
	Tariq Toukan <tariqt@...dia.com>
Subject: Re: [pull request][net-next V2 00/15] mlx5 updates 2023-10-19

On Tue, Oct 24, 2023 at 06:02:51PM -0700, Jakub Kicinski wrote:
> On Fri, 20 Oct 2023 23:46:05 -0700 Saeed Mahameed wrote:
> >   - Add missing Fixes tags
> 
> Fixes for bugs present in net need to go to net..
> We are pretty strict about that, is there any context I'm missing?

This patch won't fix much without following patch in that series.
https://lore.kernel.org/all/20231021064620.87397-8-saeed@kernel.org/

Yes, users will see their replay window correctly through "ip xfrm state"
command, so this is why it has Fixes line, but it won't change anything
in the actual behavior without patch 7 and this is the reason why it was
sent to net-next.

>From patch 3:
 Users can configure IPsec replay window size, but mlx5 driver didn't
 honor their choice and set always 32bits.

>From patch 7:
 After IPsec decryption it isn't enough to only check the IPsec syndrome
 but need to also check the ASO syndrome in order to verify that the
 operation was actually successful.

Thanks