netdev - Re: [PATCH iwl-next] i40e: Delete unused and useless i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 26 Oct 2023 11:33:46 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Ivan Vecera <ivecera@...hat.com>, <netdev@...r.kernel.org>
CC: Jesse Brandeburg <jesse.brandeburg@...el.com>, Tony Nguyen
	<anthony.l.nguyen@...el.com>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, <intel-wired-lan@...ts.osuosl.org>,
	<linux-kernel@...r.kernel.org>, Jacob Keller <jacob.e.keller@...el.com>,
	Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [PATCH iwl-next] i40e: Delete unused and useless i40e_pf fields

On 10/25/23 16:59, Ivan Vecera wrote:
> Removed fields:
> .fc_autoneg_status
>      Since commit c56999f94876 ("i40e/i40evf: Add set_fc and init of
>      FC settings") write-only and otherwise unused
> .eeprom_version
>      Write-only and otherwise unused
> .atr_sample_rate
>      Has only one possible value (I40E_DEFAULT_ATR_SAMPLE_RATE). Remove
>      it and replace its occurrences by I40E_DEFAULT_ATR_SAMPLE_RATE
> .adminq_work_limit
>      Has only one possible value (I40E_AQ_WORK_LIMIT). Remove it and
>      replace its occurrences by I40E_AQ_WORK_LIMIT
> .tx_sluggish_count
>      Unused, never written
> .pf_seid
>      Used to store VSI downlink seid and it is referenced only once
>      in the same codepath. There is no need to save it into i40e_pf.
>      Remove it and use downlink_seid directly in the mentioned log
>      message.
> .instance
>      Write only. Remove it as well as ugly static local variable
>      'pfs_found' in i40e_probe.
> .int_policy
> .switch_kobj
> .ptp_pps_work
> .ptp_extts1_work
> .ptp_pps_start
> .pps_delay
> .ptp_pin
> .override_q_count
>      All these unused at all
> 
> Prior the patch:
> pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
>          /* size: 5368, cachelines: 84, members: 127 */
>          /* sum members: 5297, holes: 20, sum holes: 71 */
>          /* paddings: 6, sum paddings: 19 */
>          /* last cacheline: 56 bytes */
> };
> 
> After the patch:
> pahole -Ci40e_pf drivers/net/ethernet/intel/i40e/i40e.ko | tail -5
>          /* size: 4976, cachelines: 78, members: 112 */
>          /* sum members: 4905, holes: 17, sum holes: 71 */
>          /* paddings: 6, sum paddings: 19 */
>          /* last cacheline: 48 bytes */
> };
> 
> Signed-off-by: Ivan Vecera <ivecera@...hat.com>
> ---
>   drivers/net/ethernet/intel/i40e/i40e.h         | 16 ----------------
>   drivers/net/ethernet/intel/i40e/i40e_debugfs.c |  3 ---
>   drivers/net/ethernet/intel/i40e/i40e_main.c    | 18 ++++--------------
>   3 files changed, 4 insertions(+), 33 deletions(-)
>

[...]

> @@ -12831,7 +12830,6 @@ static int i40e_sw_init(struct i40e_pf *pf)
>   					I40E_MAX_VF_COUNT);
>   	}
>   #endif /* CONFIG_PCI_IOV */
> -	pf->eeprom_version = 0xDEAD;

haha, dead indeed!

[...]

Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>