netdev - Re: [PATCH net-next V1] net: pcs: xpcs: Add 2500BASE-X case in get state for XPCS drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZToq3n26jDqiueTB@shell.armlinux.org.uk>
Date: Thu, 26 Oct 2023 10:01:18 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Raju Lakkaraju <Raju.Lakkaraju@...rochip.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
	linux-kernel@...r.kernel.org, andrew@...n.ch,
	Jose.Abreu@...opsys.com, fancer.lancer@...il.com,
	UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH net-next V1] net: pcs: xpcs: Add 2500BASE-X case in get
 state for XPCS drivers

On Thu, Oct 26, 2023 at 11:13:05AM +0530, Raju Lakkaraju wrote:
> +	sts = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_STS);
> +
> +	state->link = !!(sts & DW_VR_MII_MMD_STS_LINK_STS);
> +	if (!state->link) {
> +		state->speed = SPEED_UNKNOWN;
> +		state->pause = MLO_PAUSE_NONE;
> +		state->duplex = DUPLEX_UNKNOWN;
> +		return 0;
> +	}

You don't need this. If autoneg is enabled then these are initialised
prior to calling this by phylink using:

                state->speed = SPEED_UNKNOWN;
                state->duplex = DUPLEX_UNKNOWN;
                state->pause = MLO_PAUSE_NONE;

or if not using autoneg:

                state->speed =  pl->link_config.speed;
                state->duplex = pl->link_config.duplex;
                state->pause = pl->link_config.pause;

so you don't need to touch them if the link is down.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!