netdev - Re: [PATCH bpf-next 2/2] netkit: use netlink policy for mode and policy attributes validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTpoNuFuE1BYLqeB@nanopsycho>
Date: Thu, 26 Oct 2023 15:23:02 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Nikolay Aleksandrov <razor@...ckwall.org>
Cc: bpf@...r.kernel.org, netdev@...r.kernel.org, martin.lau@...ux.dev,
	ast@...nel.org, andrii@...nel.org, john.fastabend@...il.com,
	kuba@...nel.org, andrew@...n.ch, toke@...nel.org, toke@...hat.com,
	sdf@...gle.com, daniel@...earbox.net
Subject: Re: [PATCH bpf-next 2/2] netkit: use netlink policy for mode and
 policy attributes validation

Thu, Oct 26, 2023 at 11:41:06AM CEST, razor@...ckwall.org wrote:
>Use netlink's NLA_POLICY_VALIDATE_FN() type for mode and primary/peer
>policy with custom validation functions to return better errors. This
>simplifies the logic a bit and relies on netlink's policy validation.
>We don't have to specify len because the type is NLA_U32 and attribute
>length is enforced by netlink.
>
>Suggested-by: Jiri Pirko <jiri@...nulli.us>
>Signed-off-by: Nikolay Aleksandrov <razor@...ckwall.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>