netdev - Re: [PATCH v1 net-next 00/12] tcp: Refactor bhash2 and remove sk_bind2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 26 Oct 2023 15:35:15 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Kuniyuki Iwashima <kuniyu@...zon.com>, "David S. Miller" <davem@...emloft.net>, 
	Jakub Kicinski <kuba@...nel.org>, David Ahern <dsahern@...nel.org>, Coco Li <lixiaoyan@...gle.com>, 
	Kuniyuki Iwashima <kuni1840@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v1 net-next 00/12] tcp: Refactor bhash2 and remove sk_bind2_node.

On Thu, Oct 26, 2023 at 12:18 PM Paolo Abeni <pabeni@...hat.com> wrote:
>
> On Mon, 2023-10-23 at 12:02 -0700, Kuniyuki Iwashima wrote:
> > This series refactors code around bhash2 and remove some bhash2-specific
> > fields, sock.sk_bind2_node, and inet_timewait_sock.tw_bind2_node.
> >
> >   patch 1      : optimise bind() for non-wildcard v4-mapped-v6 address
> >   patch 2 -  4 : optimise bind() conflict tests
> >   patch 5 - 12 : Link bhash2 to bhash and unlink sk from bhash2 to
> >                  remove sk_bind2_node
> >
> > The patch 8 will trigger a false-positive error by checkpatch.
> >
> > This series will affect the recent work by Coco Li reorganising major
> > structs.
>
> Given the above implicit dependency, the fact the the struct reorg is
> almost in a ready state, that we are at the end of the cycle and that
> this series has the potential to bring some non trivial side effect, I
> think it would be better to post-pone this series to the next cycle.

I agree, I do not see an urgent need for this refactor yet.