netdev - Re: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231026072003.65dc5774@kernel.org>
Date: Thu, 26 Oct 2023 07:20:03 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Coco Li <lixiaoyan@...gle.com>
Cc: Eric Dumazet <edumazet@...gle.com>, Neal Cardwell
 <ncardwell@...gle.com>, Mubashir Adnan Qureshi <mubashirq@...gle.com>,
 Paolo Abeni <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Jonathan
 Corbet <corbet@....net>, David Ahern <dsahern@...nel.org>, Daniel Borkmann
 <daniel@...earbox.net>, netdev@...r.kernel.org, Chao Wu
 <wwchao@...gle.com>, Wei Wang <weiwan@...gle.com>, Pradeep Nemavat
 <pnemavat@...gle.com>
Subject: Re: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path
 variables

On Thu, 26 Oct 2023 08:19:56 +0000 Coco Li wrote:
> Subject: [PATCH v4 net-next 3/6] net-smnp: reorganize SNMP fast path variables

s/smnp/snmp/

> names of the metrics. User space binaries not ignoreing the

ignoring

> +/* Enums in this file are exported by their name and by
> + * their values. User space binaries should ingest both
> + * of the above, and therefore ordering changes in this
> + * file does not break user space. For an example, please
> + * see the output of /proc/net/netstat.

I don't understand, what does it mean to be exposed by value?
User space uses the enum to offset into something or not?
If not why don't we move the enum out of uAPI entirely?

> +	/* Caacheline organization can be found documented in

Cacheline

Please invest (your time) a spell check :S