netdev - Re: [PATCH net-next] bnxt_en: Fix 2 stray ethtool -S counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <082150a7-f2f1-40bf-aa4d-81d4b6f5ce40@intel.com>
Date: Thu, 26 Oct 2023 16:35:54 +0200
From: Wojciech Drewek <wojciech.drewek@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Michael Chan <michael.chan@...adcom.com>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>, <edumazet@...gle.com>, <pabeni@...hat.com>,
	<gospo@...adcom.com>, Ajit Khaparde <ajit.khaparde@...adcom.com>
Subject: Re: [PATCH net-next] bnxt_en: Fix 2 stray ethtool -S counters



On 26.10.2023 16:28, Jakub Kicinski wrote:
> On Thu, 26 Oct 2023 12:36:37 +0200 Wojciech Drewek wrote:
>>> Fixes: 754fbf604ff6 ("bnxt_en: Update firmware interface to 1.10.2.171")  
>>
>> If this is a fix than the target should be "net" not "net-next".
> 
> The commit in question hasn't reached net yet, this is the second time
> you're going this incorrect feedback:
> 
> https://lore.kernel.org/all/20231023093256.0dd8f145@kernel.org/

Sorry, I somehow missed your comment.

> 
>> You don't need "len" var.
>> Why not just:
>> 	num_stats += min_t(int, bp->fw_rx_stats_ext_size,
>> 			   ARRAY_SIZE(bnxt_port_stats_ext_arr));
> 
> I think it's needed to make sure lines don't go over 80 chars.

Makes sense