lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <MN0PR21MB32649DAC2B9A6CE863B320B1CEDDA@MN0PR21MB3264.namprd21.prod.outlook.com> Date: Thu, 26 Oct 2023 21:04:46 +0000 From: Long Li <longli@...rosoft.com> To: Stephen Hemminger <stephen@...workplumber.org>, "longli@...uxonhyperv.com" <longli@...uxonhyperv.com> CC: KY Srinivasan <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org> Subject: RE: [PATCH] hv_netvsc: Mark VF as slave before exposing it to user-mode > Subject: Re: [PATCH] hv_netvsc: Mark VF as slave before exposing it to user-mode > > On Wed, 25 Oct 2023 15:50:50 -0700 > longli@...uxonhyperv.com wrote: > > > list_for_each_entry(ndev_ctx, &netvsc_dev_list, list) { > > ndev = hv_get_drvdata(ndev_ctx->device_ctx); > > - if (ether_addr_equal(vf_netdev->perm_addr, ndev->perm_addr)) > { > > - netdev_notice(vf_netdev, > > - "falling back to mac addr based > matching\n"); > > + if (ether_addr_equal(vf_netdev->perm_addr, ndev->perm_addr) > || > > + ether_addr_equal(vf_netdev->dev_addr, ndev->perm_addr)) > > This part looks like unrelated change. > The VF mac address shouldn't change, but if it did don't look at i. At the time of NETDEV_POST_INIT, the perm_addr is not assigned yet (last it was copied from dev_addr when device is registered).
Powered by blists - more mailing lists