netdev - Re: [PATCH net-next 4/5] net: phy: broadcom: Add support for WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231026145644.58a8bd90@kernel.org>
Date: Thu, 26 Oct 2023 14:56:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Florian Fainelli <florian.fainelli@...adcom.com>
Cc: Vincent MAILHOL <mailhol.vincent@...adoo.fr>, netdev@...r.kernel.org,
 Doug Berger <opendmb@...il.com>, Broadcom internal kernel review list
 <bcm-kernel-feedback-list@...adcom.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Vladimir
 Oltean <vladimir.oltean@....com>, Tariq Toukan <tariqt@...dia.com>, Gal
 Pressman <gal@...dia.com>, Willem de Bruijn <willemb@...gle.com>, Daniil
 Tatianin <d-tatianin@...dex-team.ru>, Simon Horman <horms@...nel.org>,
 Justin Chen <justin.chen@...adcom.com>, Ratheesh Kannoth
 <rkannoth@...vell.com>, Joe Damato <jdamato@...tly.com>, Jiri Pirko
 <jiri@...nulli.us>, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 4/5] net: phy: broadcom: Add support for
 WAKE_FILTER

On Thu, 26 Oct 2023 10:55:10 -0700 Florian Fainelli wrote:
> >> Also, did you run parse to check your endianness conversions?  
> 
> I did, though nothing came out with C=1 or C=2, I might have to check 
> that separately.

FWIW

drivers/net/phy/bcm-phy-lib.c:1128:42: warning: cast to restricted __be16
drivers/net/phy/bcm-phy-lib.c:1128:40: warning: incorrect type in assignment (different base types)
drivers/net/phy/bcm-phy-lib.c:1128:40:    expected restricted __be16 [usertype] h_proto
drivers/net/phy/bcm-phy-lib.c:1128:40:    got unsigned short [usertype]
drivers/net/phy/bcm-phy-lib.c:1188:17: warning: incorrect type in assignment (different base types)
drivers/net/phy/bcm-phy-lib.c:1188:17:    expected restricted __be16 [usertype] h_proto
drivers/net/phy/bcm-phy-lib.c:1188:17:    got unsigned short [usertype]
drivers/net/phy/bcm-phy-lib.c:1190:25: warning: incorrect type in assignment (different base types)
drivers/net/phy/bcm-phy-lib.c:1190:25:    expected restricted __be16 [usertype] h_proto
drivers/net/phy/bcm-phy-lib.c:1190:25:    got int
drivers/net/phy/bcm-phy-lib.c:1193:33: warning: incorrect type in argument 3 (different base types)
drivers/net/phy/bcm-phy-lib.c:1193:33:    expected unsigned short [usertype] val
drivers/net/phy/bcm-phy-lib.c:1193:33:    got restricted __be16 [usertype] h_proto
-- 
pw-bot: cr