netdev - Re: [PATCH net] llc: verify mac len before reading mac header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-J15HqBrzJ_tFSS82Kp_F3sWYH3pPQb+jRL0jT-vT61cQ@mail.gmail.com>
Date: Wed, 25 Oct 2023 19:18:59 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com, 
	pabeni@...hat.com, Willem de Bruijn <willemb@...gle.com>, 
	syzbot+a8c7be6dee0de1b669cc@...kaller.appspotmail.com
Subject: Re: [PATCH net] llc: verify mac len before reading mac header

On Wed, Oct 25, 2023 at 7:14 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 25 Oct 2023 19:05:59 -0400 Willem de Bruijn wrote:
> > > I think this one may want 1 to indicate error, technically. No?
> >
> > Absolutely, thanks. For both tests.
>
> Both state machine callbacks (functions with names ending with 'test_r'
> in the patch), right? Perhaps 'goto out' is what's expected here.
>
> The fixup function seems to have inverse return semantics, because
> why not.

Exactly :) Extrapolating from that is where I went wrong.