netdev - RE: [PATCH net-next] nfp: using napi_build_skb() to replace build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <DM6PR13MB370503098CEFC598094BB764FCDDA@DM6PR13MB3705.namprd13.prod.outlook.com>
Date: Thu, 26 Oct 2023 02:04:33 +0000
From: Yinjun Zhang <yinjun.zhang@...igine.com>
To: Wojciech Drewek <wojciech.drewek@...el.com>, Louis Peens
	<louis.peens@...igine.com>, David Miller <davem@...emloft.net>, Jakub
 Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
CC: Fei Qin <fei.qin@...hogine.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, oss-drivers <oss-drivers@...igine.com>
Subject: RE: [PATCH net-next] nfp: using napi_build_skb() to replace
 build_skb()


On Wednesday, October 25, 2023 4:47 PM, Wojciech Drewek wrote:
> On 25.10.2023 09:41, Louis Peens wrote:
> > @@ -1363,7 +1363,7 @@ nfp_ctrl_rx_one(struct nfp_net *nn, struct
> nfp_net_dp *dp,
> 
> Hi Louis,
> I'm not an expert regarding NAPI but I think napi_build_skb should be used in
> napi context.
> From what I see nfp_ctrl_rx_one is used after calling nfp_nfdk_ctrl_poll which
> is scheduled
> using tasklet_setup, not using napi_schedule.
> Am I right?
> 

Thanks for pointing this out. I think it won't cause any technical problem since
tasklet is also in soft_irq context(correct me if I'm wrong here). But I agree that
let's follow the convention of not using it outside napi context. Will send v2 to
drop the change.