netdev - Re: [PATCH 3/3] checkpatch: add ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7e45f79e04cf28b69300cc12cf47267fb216955.camel@perches.com>
Date: Wed, 25 Oct 2023 16:52:58 -0700
From: Joe Perches <joe@...ches.com>
To: Justin Stitt <justinstitt@...gle.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Shay Agroskin
 <shayagr@...zon.com>, Arthur Kiyanovski <akiyano@...zon.com>, David Arinzon
 <darinzon@...zon.com>, Noam Dagan <ndagan@...zon.com>, Saeed Bishara
 <saeedb@...zon.com>, Rasesh Mody <rmody@...vell.com>, Sudarsana Kalluru
 <skalluru@...vell.com>, GR-Linux-NIC-Dev@...vell.com, Dimitris Michailidis
 <dmichail@...gible.com>, Yisen Zhuang <yisen.zhuang@...wei.com>, Salil
 Mehta <salil.mehta@...wei.com>, Jesse Brandeburg
 <jesse.brandeburg@...el.com>,  Tony Nguyen <anthony.l.nguyen@...el.com>,
 Louis Peens <louis.peens@...igine.com>, Shannon Nelson
 <shannon.nelson@....com>, Brett Creeley <brett.creeley@....com>, 
 drivers@...sando.io, "K. Y. Srinivasan" <kys@...rosoft.com>, Haiyang Zhang
 <haiyangz@...rosoft.com>, Wei Liu <wei.liu@...nel.org>, Dexuan Cui
 <decui@...rosoft.com>, Ronak Doshi <doshir@...are.com>, VMware PV-Drivers
 Reviewers <pv-drivers@...are.com>, Andy Whitcroft <apw@...onical.com>,
 Dwaipayan Ray <dwaipayanray1@...il.com>, Lukas Bulwahn
 <lukas.bulwahn@...il.com>
Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Nick Desaulniers
 <ndesaulniers@...gle.com>, Nathan Chancellor <nathan@...nel.org>, Kees Cook
 <keescook@...omium.org>, intel-wired-lan@...ts.osuosl.org, 
 oss-drivers@...igine.com, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH 3/3] checkpatch: add ethtool_sprintf rules

On Wed, 2023-10-25 at 23:40 +0000, Justin Stitt wrote:
> Add some warnings for using ethtool_sprintf() where a simple
> ethtool_puts() would suffice.
> 
> The two cases are:
> 
> 1) Use ethtool_sprintf() with just two arguments:
> >       ethtool_sprintf(&data, driver[i].name);

OK.

> or
> 2) Use ethtool_sprintf() with a standalone "%s" fmt string:
> >       ethtool_sprintf(&data, "%s", driver[i].name);

I'm rather doubt this is really desired or appropriate.