netdev - Re: [PATCH net-next] netlink: specs: support conditional operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZToBkrWEh2Yn/Dqb@nanopsycho>
Date: Thu, 26 Oct 2023 08:05:06 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
	pabeni@...hat.com
Subject: Re: [PATCH net-next] netlink: specs: support conditional operations

Wed, Oct 25, 2023 at 06:22:53PM CEST, kuba@...nel.org wrote:
>Page pool code is compiled conditionally, but the operations
>are part of the shared netlink family. We can handle this
>by reporting empty list of pools or -EOPNOTSUPP / -ENOSYS
>but the cleanest way seems to be removing the ops completely
>at compilation time. That way user can see that the page
>pool ops are not present using genetlink introspection.
>Same way they'd check if the kernel is "new enough" to
>support the ops.
>
>Extend the specs with the ability to specify the config
>condition under which op (and its policies, etc.) should
>be hidden.
>
>Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Jiri Pirko <jiri@...dia.com>