netdev - Re: [PATCH v17 02/20] netlink: add new family to manage ULP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZTuCxUJnQM509L8e@nanopsycho>
Date: Fri, 27 Oct 2023 11:28:37 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Aurelien Aptel <aaptel@...dia.com>
Cc: linux-nvme@...ts.infradead.org, netdev@...r.kernel.org,
	sagi@...mberg.me, hch@....de, kbusch@...nel.org, axboe@...com,
	chaitanyak@...dia.com, davem@...emloft.net, kuba@...nel.org,
	aurelien.aptel@...il.com, smalin@...dia.com, malin1024@...il.com,
	ogerlitz@...dia.com, yorayz@...dia.com, borisp@...dia.com,
	galshalom@...dia.com, mgurtovoy@...dia.com, edumazet@...gle.com,
	pabeni@...hat.com, imagedong@...cent.com
Subject: Re: [PATCH v17 02/20] netlink: add new family to manage ULP_DDP
 enablement and stats

Fri, Oct 27, 2023 at 11:11:19AM CEST, aaptel@...dia.com wrote:

[..]

>
>>>+      notify = !!ret;
>>>+      ret = prepare_data(data, ULP_DDP_CMD_SET);
>>
>> Why you send it back for set? (leaving notify aside)
>
>We send back the final caps so userspace can see and compare what was
>requested vs the result of what the driver could enable.
>This is following the convention of ethtool features.

Okay.

[..]