netdev - Re: [PATCH net-next v8 5/7] net: phy: nxp-c45-tja11xx: add MACsec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 27 Oct 2023 07:02:38 +0800
From: kernel test robot <lkp@...el.com>
To: "Radu Pirea (NXP OSS)" <radu-nicolae.pirea@....nxp.com>,
	sd@...asysnail.net, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, andrew@...n.ch,
	hkallweit1@...il.com, linux@...linux.org.uk,
	richardcochran@...il.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, sebastian.tobuschat@....nxp.com,
	"Radu Pirea (NXP OSS)" <radu-nicolae.pirea@....nxp.com>
Subject: Re: [PATCH net-next v8 5/7] net: phy: nxp-c45-tja11xx: add MACsec
 support

Hi Radu,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Radu-Pirea-NXP-OSS/net-macsec-move-sci_to_cpu-to-macsec-header/20231023-174539
base:   net-next/main
patch link:    https://lore.kernel.org/r/20231023094327.565297-6-radu-nicolae.pirea%40oss.nxp.com
patch subject: [PATCH net-next v8 5/7] net: phy: nxp-c45-tja11xx: add MACsec support
config: x86_64-randconfig-103-20231026 (https://download.01.org/0day-ci/archive/20231027/202310270618.i3W3qKiJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231027/202310270618.i3W3qKiJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310270618.i3W3qKiJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   ld: drivers/net/phy/nxp-c45-tja11xx-macsec.o: in function `nxp_c45_handle_macsec_interrupt':
>> drivers/net/phy/nxp-c45-tja11xx-macsec.c:1330: undefined reference to `macsec_pn_wrapped'


vim +1330 drivers/net/phy/nxp-c45-tja11xx-macsec.c

  1299	
  1300	void nxp_c45_handle_macsec_interrupt(struct phy_device *phydev,
  1301					     irqreturn_t *ret)
  1302	{
  1303		struct nxp_c45_phy *priv = phydev->priv;
  1304		struct nxp_c45_secy *pos, *tmp;
  1305		struct nxp_c45_sa *sa;
  1306		u8 encoding_sa;
  1307		int secy_id;
  1308		u32 reg = 0;
  1309	
  1310		if (!priv->macsec)
  1311			return;
  1312	
  1313		do {
  1314			nxp_c45_macsec_read(phydev, MACSEC_EVR, &reg);
  1315			if (!reg)
  1316				return;
  1317	
  1318			secy_id = MACSEC_REG_SIZE - ffs(reg);
  1319			list_for_each_entry_safe(pos, tmp, &priv->macsec->secy_list,
  1320						 list)
  1321				if (pos->secy_id == secy_id)
  1322					break;
  1323	
  1324			encoding_sa = pos->secy->tx_sc.encoding_sa;
  1325			phydev_dbg(phydev, "pn_wrapped: TX SC %d, encoding_sa %u\n",
  1326				   pos->secy_id, encoding_sa);
  1327	
  1328			sa = nxp_c45_find_sa(&pos->sa_list, TX_SA, encoding_sa);
  1329			if (!IS_ERR(sa))
> 1330				macsec_pn_wrapped(pos->secy, sa->sa);

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki