netdev - Re: [PATCH net-next v2 2/5] net: ethtool: Add validation for WAKE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b331eca9-5345-49e9-8e44-7c18045ac7f9@intel.com>
Date: Thu, 26 Oct 2023 16:19:06 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Florian Fainelli <florian.fainelli@...adcom.com>, <netdev@...r.kernel.org>
CC: Doug Berger <opendmb@...il.com>, Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Andrew Lunn
	<andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>, Russell King
	<linux@...linux.org.uk>, Vladimir Oltean <vladimir.oltean@....com>, "Tariq
 Toukan" <tariqt@...dia.com>, Gal Pressman <gal@...dia.com>, Willem de Bruijn
	<willemb@...gle.com>, Daniil Tatianin <d-tatianin@...dex-team.ru>, "Simon
 Horman" <horms@...nel.org>, Justin Chen <justin.chen@...adcom.com>, "Ratheesh
 Kannoth" <rkannoth@...vell.com>, Joe Damato <jdamato@...tly.com>, "Vincent
 Mailhol" <mailhol.vincent@...adoo.fr>, Jiri Pirko <jiri@...nulli.us>, "open
 list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v2 2/5] net: ethtool: Add validation for
 WAKE_FILTER



On 10/26/2023 3:45 PM, Florian Fainelli wrote:
> A driver implementing WAKE_FILTER must first install at least one rule
> with RX_CLS_FLOW_WAKE for WAKE_FILTER to be effective. Iterate over
> RXNFC rules to validate that condition while trying to enable
> WAKE_FILTER.
> 

Makes sense to enforce this.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>