netdev - Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <469fc880-016d-4b92-9fb3-7b465a1a8046@lunn.ch>
Date: Fri, 27 Oct 2023 22:20:44 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Luiz Angelo Daros de Luca <luizluca@...il.com>
Cc: netdev@...r.kernel.org, linus.walleij@...aro.org, alsi@...g-olufsen.dk,
	vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com,
	davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
	robh+dt@...nel.org, krzk+dt@...nel.org, arinc.unal@...nc9.com
Subject: Re: [PATCH net-next v2 3/3] net: dsa: realtek: support reset
 controller

> -	/* TODO: if power is software controlled, set up any regulators here */

Please don't remove these comments. The switch might be powered using
a regulator. And this does look like the correct place to get the
regulator, and turn it on before doing the reset. Somebody thought
such boards might exist...

> -	/* TODO: if power is software controlled, set up any regulators here */

etc.

    Andrew

---
pw-bot: cr